[improve][broker]consumer backlog eviction policy should not reset read position for consumer #18037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osition for consumer
Technoboy-
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #18037 +/- ##
=========================================
Coverage ? 43.90%
Complexity ? 10604
=========================================
Files ? 1180
Lines ? 84791
Branches ? 9638
=========================================
Hits ? 37229
Misses ? 43882
Partials ? 3680
Flags with carried forward coverage won't be shown. Click here to find out more. |
AnonHxy
approved these changes
Oct 14, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
Outdated
Show resolved
Hide resolved
|
LGTM with minor comment |
|
|
It is due to the test topic and subscription are reused by other test cases, which I have fixed already. |
|
/pulsarbot run-failure-checks |
|
Pulsar Flaky tests failed due to #17921 |
HQebupt
requested review from
codelipenghui,
Technoboy-,
gaozhangmin and
Jason918
gaozhangmin
approved these changes
Oct 18, 2022
HQebupt
changed the title
5 tasks
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 9, 2022
…ad position for consumer (apache#18037) Fixes apache#18036 - The backlog eviction policy should use `asyncMarkDelete` instead of `resetCursor` in order to move the mark delete position. (cherry picked from commit 0b7140b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #18036
Modifications
asyncMarkDeleteinstead ofresetCursorin order to move the mark delete position.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-requireddoc-not-neededdocdoc-completeMatching PR in forked repository
PR in forked repository: HQebupt#5