Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][branch-2.10]wrong metrics text generated when label_cluster specified (#17704) #18919

Merged
merged 3 commits into from
Dec 15, 2022
Merged

[cherry-pick][branch-2.10]wrong metrics text generated when label_cluster specified (#17704) #18919

merged 3 commits into from
Dec 15, 2022

Conversation

liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Dec 14, 2022

Motivation

Cherry-pick #17704 for release 2.10.3 and run tests.

Modifications

Cherry-pick #17704

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

…ed (#17704)

* [fix][metrics]wrong metrics text generated when label_cluster specified

* improve logic branch

* mark test group

(cherry picked from commit 518cdcd)
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 14, 2022
@liangyepianzhou liangyepianzhou changed the title [fix][metrics]wrong metrics text generated when label_cluster specified (#17704) [cherry-pick][branch-2.10]wrong metrics text generated when label_cluster specified (#17704) Dec 14, 2022
@liangyepianzhou liangyepianzhou merged commit a530ab2 into apache:branch-2.10 Dec 15, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
…ster specified (apache#17704) (apache#18919)

Co-authored-by: fengyubiao <[email protected]>
(cherry picked from commit a530ab2)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
…ster specified (apache#17704) (apache#18919)

Co-authored-by: fengyubiao <[email protected]>
(cherry picked from commit a530ab2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants