-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [admin] set ns level backlog quota does not take effect if retention exists #20690
Merged
poorbarcode
merged 1 commit into
apache:master
from
poorbarcode:fix/set_ns_backlog_quota
Jun 30, 2023
Merged
[fix] [admin] set ns level backlog quota does not take effect if retention exists #20690
poorbarcode
merged 1 commit into
apache:master
from
poorbarcode:fix/set_ns_backlog_quota
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@poorbarcode Please add the following content to your PR description and select a checkbox:
|
poorbarcode
changed the title
[fix] [admin] set ns level backlog quota does not take effect if rete
[fix] [admin] set ns level backlog quota does not take effect if retention exists
Jun 30, 2023
github-actions
bot
added
doc-not-needed
Your PR changes do not impact docs
and removed
doc-label-missing
labels
Jun 30, 2023
poorbarcode
added
type/bug
The PR fixed a bug or issue reported a bug
area/admin
labels
Jun 30, 2023
mattisonchao
approved these changes
Jun 30, 2023
codelipenghui
approved these changes
Jun 30, 2023
Technoboy-
approved these changes
Jun 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #20690 +/- ##
============================================
+ Coverage 72.60% 73.10% +0.50%
- Complexity 32018 32059 +41
============================================
Files 1855 1869 +14
Lines 138569 138848 +279
Branches 15250 15271 +21
============================================
+ Hits 100605 101502 +897
+ Misses 29945 29290 -655
- Partials 8019 8056 +37
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
added a commit
that referenced
this pull request
Jun 30, 2023
…ntion exists (#20690) Motivation: When a retention policy exists, the command `pulsar-admin namespaces set-backlog-quota` does not take effect.In the PR #17383: it only checked the compatibility of `retention` and `backlog quota`, and it was not set. Modifications: Fix the bug. (cherry picked from commit 6acd01d)
poorbarcode
added
cherry-picked/branch-3.0
release/3.0.1
and removed
release/3.0.2
labels
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/admin
cherry-picked/branch-3.0
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a retention policy exists, the command
pulsar-admin namespaces set-backlog-quota
does not take effect.In the PR #17383: it only checked the compatibility of
retention
andbacklog quota
, and it was not set.Modifications
Fix the bug.
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x