-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-330: getMessagesById gets all messages #21873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
changed the title
[improve][pip] getMessageById gets all messages
[improve][pip] PIP-330: getMessageById gets all messages
Jan 10, 2024
github-actions
bot
added
type/PIP
doc
Your PR contains doc changes, no matter whether the changes are in markdown or code files.
labels
Jan 10, 2024
asafm
reviewed
Jan 10, 2024
liudezhi2098
requested review from
Technoboy-,
BewareMyPower and
poorbarcode
and removed request for
asafm
January 11, 2024 02:21
I support all @BewareMyPower latest comments. Once PR is updated, could you ping me? |
Ping @asafm and @BewareMyPower, this PR has been updated. |
asafm
approved these changes
Jan 15, 2024
nodece
changed the title
[improve][pip] PIP-330: getMessageById gets all messages
[improve][pip] PIP-330: getMessagesById gets all messages
Jan 15, 2024
Signed-off-by: Zixuan Liu <[email protected]>
RobertIndie
approved these changes
Jan 15, 2024
BewareMyPower
approved these changes
Jan 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A PIP proposal adds a new
getMessagesById
to get all messages.Documentation
doc
doc-required
doc-not-needed
doc-complete