-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-321 Introduce allowed-cluster at the namespace level #22378
Merged
Technoboy-
merged 18 commits into
apache:master
from
liangyepianzhou:replication/topic-level
Jun 20, 2024
Merged
[feat][broker] PIP-321 Introduce allowed-cluster at the namespace level #22378
Technoboy-
merged 18 commits into
apache:master
from
liangyepianzhou:replication/topic-level
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangyepianzhou
changed the title
Replication/topic level
[feat][broker] PIP-321 Introduce allowed-cluster at the namespace level
Mar 28, 2024
liangyepianzhou
requested review from
Technoboy-,
codelipenghui and
poorbarcode
March 29, 2024 00:56
liangyepianzhou
added
the
type/feature
The PR added a new feature or issue requested a new feature
label
Mar 29, 2024
# Conflicts: # pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22378 +/- ##
============================================
- Coverage 73.57% 73.24% -0.34%
- Complexity 32624 32642 +18
============================================
Files 1877 1890 +13
Lines 139502 141584 +2082
Branches 15299 15534 +235
============================================
+ Hits 102638 103702 +1064
- Misses 28908 29888 +980
- Partials 7956 7994 +38
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Demogorgon314
force-pushed
the
replication/topic-level
branch
from
May 27, 2024 02:48
783e3d5
to
0256d3b
Compare
poorbarcode
reviewed
May 29, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
…ip the replications check
poorbarcode
approved these changes
Jun 11, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Show resolved
Hide resolved
# Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java
@gaoran10 @Technoboy- Please help review this PR. |
gaoran10
reviewed
Jun 20, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
Technoboy-
reviewed
Jun 20, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
Technoboy-
reviewed
Jun 20, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jun 20, 2024
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Jun 24, 2024
Merged
15 tasks
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Jun 24, 2024
…el (apache#22378) (cherry picked from commit 36bae69)
Merged
15 tasks
Technoboy-
pushed a commit
that referenced
this pull request
Jun 26, 2024
…el (#22378) (#22961) Co-authored-by: Xiangying Meng <[email protected]>
Demogorgon314
added a commit
that referenced
this pull request
Jul 1, 2024
…amespace level (#22378) (#22960) (cherry-picked from commit 36bae69) Co-authored-by: Xiangying Meng <[email protected]>
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…amespace level (apache#22378) (apache#22960) (cherry-picked from commit apache@36bae69) Co-authored-by: Xiangying Meng <[email protected]> (cherry picked from commit 7b2e724)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 1, 2024
…amespace level (apache#22378) (apache#22960) (cherry-picked from commit apache@36bae69) Co-authored-by: Xiangying Meng <[email protected]> (cherry picked from commit 7b2e724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc-not-needed
Your PR changes do not impact docs
ready-to-test
type/feature
The PR added a new feature or issue requested a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #21648
Motivation
Because the configurations of clusters at the namespace level are unclear, some flexible topic policies can not work as expected, e.g. geo-replication at the topic level.
Modifications
Use
replication-clusters
,allowed-clusters
to replace a singlereplication-clusters
originally in the namespace policy.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: