-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when load non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed #22580
Merged
lhotari
merged 1 commit into
apache:master
from
poorbarcode:fix/metrics_load_topic_fails
Apr 29, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
approved these changes
Apr 25, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
Show resolved
Hide resolved
poorbarcode
changed the title
[fix] [broker] [fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when load non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed
[fix] [broker] Fix metrics pulsar_topic_load_failed_count is 0 when load non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed
Apr 28, 2024
/pulsarbot rerun-failure-checks |
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed
poorbarcode
force-pushed
the
fix/metrics_load_topic_fails
branch
from
April 29, 2024 03:28
4b0dffb
to
83e0dce
Compare
Rebase master |
lhotari
approved these changes
Apr 29, 2024
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed (apache#22580) (cherry picked from commit 340d60d)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed (apache#22580) (cherry picked from commit 340d60d) (cherry picked from commit 053c455)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed (apache#22580) (cherry picked from commit 340d60d) (cherry picked from commit 053c455)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jun 7, 2024
…oad non-persistent topic fails and fix the flaky test testBrokerStatsTopicLoadFailed (apache#22580) (cherry picked from commit 340d60d) Signed-off-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20495
Motivation
BrokerServiceTest.testBrokerStatsTopicLoadFailed
always fails, so [fix][test] Disable invalid test BrokerServiceTest#testBrokerStatsTopicLoadFailed #20494 disabled it.pulsar_topic_load_failed_count
does not increase when load non-persistent topic fails[1].[1]: https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L1239-L1258
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x