-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] Retry re-validating ResourceLock with backoff after errors #22617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
requested review from
lhotari,
BewareMyPower,
poorbarcode and
mattisonchao
April 30, 2024 02:04
merlimat
changed the title
Retry re-validating ResourceLock with backoff after errors
[improve] Retry re-validating ResourceLock with backoff after errors
Apr 30, 2024
lhotari
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
codelipenghui
approved these changes
Apr 30, 2024
merlimat
force-pushed
the
metadata-session-reconnect
branch
from
May 3, 2024 17:18
a3a709d
to
936df56
Compare
merlimat
added a commit
that referenced
this pull request
May 7, 2024
merlimat
added a commit
that referenced
this pull request
May 7, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 13, 2024
…pache#22617) (cherry picked from commit b0542b3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…pache#22617) (cherry picked from commit b0542b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.5
release/3.2.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ResourceLock revalidation, after a session expiry, is only getting triggered after the signal of session reconnected. If this is not coming through, there is no further attempt to re-validate and re-acquire the lock.
We should improve the logic to also add timed-based retry logic, with exponential backoff.
Modifications
Backoff
class frompulsar-client
->pulsar-common
so that it can be used frompulsar-metadata
module.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: