Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Test was leaving client instance to null #22631

Merged
merged 1 commit into from
May 1, 2024

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented May 1, 2024

Motivation

The change in #22500 is leaving the pulsarClient object as null and other tests are bound to fail

Modifications

Ensuring the pulsarClient variable is always restored to a valid instance.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@merlimat merlimat added this to the 3.3.0 milestone May 1, 2024
@merlimat merlimat self-assigned this May 1, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 1, 2024
@merlimat merlimat merged commit a904863 into apache:master May 1, 2024
54 of 57 checks passed
@merlimat merlimat deleted the fix-test-condition branch May 1, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants