[fix][broker] usedLocallySinceLastReport should always be reset #22672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
fix-usedLocallySinceLastReport-reset
branch
from
e21f48d
to
2388981
Compare
nodece
added a commit
to nodece/pulsar
that referenced
this pull request
May 10, 2024
…he#22672) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nodece
added a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nodece
added a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nodece
added a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nodece
added a commit
that referenced
this pull request
May 10, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 13, 2024
…he#22672) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 15, 2024
…he#22672) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8) (cherry picked from commit 6b68a8d)
nodece
added a commit
to ascentstream/pulsar
that referenced
this pull request
May 15, 2024
…he#22672) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 16, 2024
…he#22672) Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 8f015d8) (cherry picked from commit 6b68a8d)
Technoboy-
pushed a commit
that referenced
this pull request
Jun 6, 2024
Signed-off-by: Zixuan Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
org.apache.pulsar.broker.resourcegroup.ResourceGroup.PerMonitoringClassFields#usedLocallySinceLastReportholds the usage rate of ResourceGroup in the current cycle.When the report thread calls the
org.apache.pulsar.broker.resourcegroup.ResourceGroup#rgFillResourceUsageto report the ResourceGroup usage, theusedLocallySinceLastReportshould be reset.Right now, this value will be reported every 2 cycles. The correct behavior should be to report the current rate only when it exceeds or falls below 5% of the last reported value.
#22340 breaks this behavior.
Modifications
org.apache.pulsar.broker.resourcegroup.ResourceGroup.PerMonitoringClassFields#usedLocallySinceLastReportin theorg.apache.pulsar.broker.resourcegroup.ResourceGroup#setUsageInMonitoredEntity.Verifying this change
The test has been added.
Documentation
docdoc-requireddoc-not-neededdoc-complete