-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][pip] PIP-352: Event time based topic compactor #22710
Conversation
Added a comment about an unsolved challenge: #22517 (comment) |
@lhotari what are the next steps to proceed ? |
this has been addressed. |
I've described this in the email response to the discussion thread: Please start a new vote thread for PIP-352. |
can this be implemented by StrategicTwoPhaseCompactor with another compaction strategy?? |
Not really StrategicTwoPhaseCompactor is specifically utilized for internal load balancing purposes and is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PIP-352 has been approved in this voting thread: https://lists.apache.org/thread/pp6c0qqw51yjw9szsnl2jbgjsqrx7wkn
PIP: 352
Motivation
Currently, there are two types of compactors
available:
TwoPhaseCompactor
andStrategicTwoPhaseCompactor
. The latteris specifically utilized for internal load balancing purposes and is not
employed for regular compaction of Pulsar topics. On the other hand, the
former can be configured via
CompactionServiceFactory
in thebroker.conf
.I believe it could be advantageous to introduce another type of topic
compactor that operates based on event time. Such a compactor would have
the capability to maintain desired messages within the topic while
preserving the order expected by external applications. Although
applications may send messages with the current event time, variations in
network conditions or redeliveries could result in messages being stored in
the Pulsar topic in a different order than intended. Implementing event
time-based checks could mitigate this inconvenience.
Modifications
Added PIP
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: