[improve][ml] RangeCache refactoring follow-up: use StampedLock instead of synchronized #22818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jun 3, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…ad of synchronized (apache#22818) (cherry picked from commit 208d8a5) (cherry picked from commit 62f674a)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jun 7, 2024
…ad of synchronized (apache#22818) (cherry picked from commit 208d8a5) (cherry picked from commit 62f674a)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#22814 added synchronized usage to RangeCache to ensure consistency. Synchronized usage can be avoided by the use of StampedLock
Modifications
Replace synchronized with StampedLock
Documentation
docdoc-requireddoc-not-neededdoc-complete