[fix][misc] Topic name from persistence name should decode local name

[Shawyeok]

Motivation

The methods TopicName#getPersistenceNamingEncoding and TopicName#fromPersistenceNamingEncoding should be symmetric. Currently, the localName part of the topic name is encoded into the persistence name, but it is not decoded back properly.

Modifications

This update add decoding logic for the localName part of the topic name.

Verifying this change

• Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

• A new test case has been added to org.apache.pulsar.common.naming.TopicNameTest#testFromPersistenceNamingEncoding that includes topic names with special characters.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository: Shawyeok#16

[lhotari]

@Shawyeok Just curious to know what the impact of the previous behavior was. Did it cause actual problems? Any error messages in logs?

[lhotari]

LGTM

[Shawyeok]

@Shawyeok Just curious to know what the impact of the previous behavior was. Did it cause actual problems? Any error messages in logs?

The method TopicName#fromPersistenceNamingEncoding is utilized in my downstream application to monitor the ZooKeeper paths /admin/partitioned-topics and /managed-ledger. It listens for the creation of new topics of interest and changes to topic partitions.

Moreover reviewing references in the Pulsar codebase, I noticed that this may lead to inaccuracies in the topicName label of some offloader metrics.

pulsar/tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlobStoreBackedReadHandleImplV2.java

Line 314 in ce65db9

String topicName = TopicName.fromPersistenceNamingEncoding(managedLedgerName);

[hanmz]

LGTM