[fix][broker]Fix lookupService.getTopicsUnderNamespace can not work with a quote pattern #23014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a quote pattern
poorbarcode
added
type/bug
|
/pulsarbot rerun-failure-checks |
gaoran10
reviewed
Jul 9, 2024
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicList.java
Show resolved
Hide resolved
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicList.java
Show resolved
Hide resolved
gaoran10
approved these changes
Jul 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23014 +/- ##
============================================
- Coverage 73.57% 73.45% -0.13%
- Complexity 32624 33350 +726
============================================
Files 1877 1913 +36
Lines 139502 143390 +3888
Branches 15299 15639 +340
============================================
+ Hits 102638 105322 +2684
- Misses 28908 30031 +1123
- Partials 7956 8037 +81
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Jul 10, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 12, 2024
…ith a quote pattern (apache#23014) (cherry picked from commit 7c0e827) (cherry picked from commit c0029d7)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 15, 2024
…ith a quote pattern (apache#23014) (cherry picked from commit 7c0e827) (cherry picked from commit c0029d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Background
Pattern.quotereturns a literal pattern string for the specifiedPattern.quote("123")will be\Q123\EIssue
So far,
TopicList.removeTopicDomainSchemewill remove\Qwhich is the prefix of the input string. It leadslookupService.getTopicsUnderNamespacecan not work with a quote pattern.Modifications
Fix the bug
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x