-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][client] Add exception handle for client send error #23038
[improve][client] Add exception handle for client send error #23038
Conversation
…on_handle_for_client_send_error # Conflicts: # pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java
…on_handle_for_client_send_error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix code style
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/ClientCnxTest.java
Outdated
Show resolved
Hide resolved
LGTM. But not sure why an extra blank line between the import clauses passes the checkstyle check. |
…on_handle_for_client_send_error
…on_handle_for_client_send_error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23038 +/- ##
============================================
- Coverage 73.57% 73.46% -0.12%
- Complexity 32624 33500 +876
============================================
Files 1877 1915 +38
Lines 139502 143963 +4461
Branches 15299 15730 +431
============================================
+ Hits 102638 105759 +3121
- Misses 28908 30094 +1186
- Partials 7956 8110 +154
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
(
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java
Lines 323 to 345 in 5c6602c
Modifications
receive send_error, close current producer connection, then it will reconnect automatically
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: