-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Remove blocking calls from Subscription.getStats #23088
[fix] [broker] Remove blocking calls from Subscription.getStats #23088
Conversation
4612237
to
9da7cbd
Compare
@poorbarcode Do you have the stack information for another thread which hold the lock? |
/pulsarbot rerun-failure-checks |
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23088 +/- ##
============================================
- Coverage 73.57% 73.44% -0.13%
- Complexity 32624 33516 +892
============================================
Files 1877 1917 +40
Lines 139502 144074 +4572
Branches 15299 15741 +442
============================================
+ Hits 102638 105822 +3184
- Misses 28908 30133 +1225
- Partials 7956 8119 +163
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit e59cd05)
(cherry picked from commit e59cd05)
Motivation
A deadlock occurs.
Modifications
Avoid blocking calls from
Subscription.getStats
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x