-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Handle the case when getOwnedServiceUnits
fails gracefully
#23119
Merged
BewareMyPower
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/fix-add-namespace-bundle-ownership-listener-before-lb-start
Aug 6, 2024
Merged
[fix][broker] Handle the case when getOwnedServiceUnits
fails gracefully
#23119
BewareMyPower
merged 3 commits into
apache:master
from
Demogorgon314:Demogorgon314/fix-add-namespace-bundle-ownership-listener-before-lb-start
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
added
type/bug
The PR fixed a bug or issue reported a bug
area/broker
labels
Aug 2, 2024
heesung-sn
reviewed
Aug 2, 2024
...ava/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java
Show resolved
Hide resolved
lhotari
approved these changes
Aug 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23119 +/- ##
============================================
- Coverage 73.57% 73.46% -0.11%
- Complexity 32624 33544 +920
============================================
Files 1877 1919 +42
Lines 139502 144125 +4623
Branches 15299 15748 +449
============================================
+ Hits 102638 105886 +3248
- Misses 28908 30118 +1210
- Partials 7956 8121 +165
Flags with carried forward coverage won't be shown. Click here to find out more.
|
heesung-sn
approved these changes
Aug 5, 2024
BewareMyPower
approved these changes
Aug 6, 2024
Technoboy-
pushed a commit
that referenced
this pull request
Aug 6, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 8, 2024
…fully (apache#23119) (cherry picked from commit fff41c3)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 12, 2024
…fully (apache#23119) (cherry picked from commit fff41c3)
Denovo1998
pushed a commit
to Denovo1998/pulsar
that referenced
this pull request
Aug 17, 2024
grssam
pushed a commit
to grssam/pulsar
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.2
cherry-picked/branch-3.3
doc-not-needed
Your PR changes do not impact docs
release/3.0.7
release/3.1.4
release/3.2.5
release/3.3.2
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When
getOwnedServiceUnits
fails, the broker will fail to start, we should handlegetOwnedServiceUnits
fails gracefullyModifications
getOwnedServiceUnits
fails gracefullyServiceUnitStateChannel
's tableview is null.Documentation
doc
doc-required
doc-not-needed
doc-complete