[improve][PIP] PIP-383: Support granting/revoking permissions for multiple topics #23355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
changed the title
shibd
approved these changes
Sep 27, 2024
poorbarcode
approved these changes
Sep 29, 2024
coderzc
approved these changes
Sep 29, 2024
4 tasks
RobertIndie
approved these changes
Sep 30, 2024
|
The vote has passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In AuthorizationProvider, the authorization interface
grantPermissionAsync(TopicName topicName, Set<AuthAction> actions, String role, String authDataJson)currently only supports granting permissions to a single topic.If multiple topics need to be authorized under a namespace, the client needs to call the authorization interface concurrently.
Since the permissions information are stored in the namespace-level policies, and multiple topics may be on different brokers, concurrent authorization will cause concurrent modification exceptions.
Therefore, supporting granting/revoking permissions for multiple topics is very friendly.
Documentation
docdoc-requireddoc-not-neededdoc-complete