Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] re-elect the channel owner if no channel owner is found #23516

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

heesung-sn
Copy link
Contributor

Motivation

  • There might be a chance that there is no channel owner. The existence of the channel owner(leader) needs to be monitored.

Modifications

  • Elect the channel owner(leader) if no channel owner is found in the role(leader|follower) play and monitor logic.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 25, 2024
@heesung-sn heesung-sn closed this Oct 28, 2024
@heesung-sn heesung-sn reopened this Oct 28, 2024
@heesung-sn heesung-sn merged commit 266e705 into apache:master Oct 28, 2024
72 of 75 checks passed
@lhotari
Copy link
Member

lhotari commented Nov 8, 2024

@heesung-sn is there a need to backport this change?

@heesung-sn
Copy link
Contributor Author

heesung-sn commented Nov 8, 2024

Do we still maintain 3.x branches? I thought we maintain 4.x only now.

We can backport this to 3.3 and 4.0.

@lhotari
Copy link
Member

lhotari commented Nov 8, 2024

Do we still maintain 3.x branches? I thought we maintain 4.x only now.

We can backport this to 3.3 and 4.0.

@heesung-sn We follow the schedule available at https://pulsar.apache.org/contribute/release-policy/#supported-versions . branch-3.3 will stop being in active maintenance in about 1 month. 3.0.x is maintained until May 2025.

heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Nov 9, 2024
@heesung-sn
Copy link
Contributor Author

cherry-pick pr to 3.3 #23580

heesung-sn added a commit to heesung-sn/pulsar that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants