-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Skip unloading when bundle throughput is zero (ExtensibleLoadManagerImpl only) #23626
Conversation
13b3e05
to
0d7d60a
Compare
/pulsarbot run-failure-checks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23626 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.76%
- Complexity 32624 34454 +1830
============================================
Files 1877 1944 +67
Lines 139502 147144 +7642
Branches 15299 16228 +929
============================================
+ Hits 102638 109383 +6745
- Misses 28908 29328 +420
- Partials 7956 8433 +477
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/models/TopKBundles.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
If throughput is zero, we better skip the unloading. Otherwise, leader could keep unloading zero throughput bundles back and forth.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: