[fix][ws] Implement missing http header data functions in AuthenticationDataSubscription #23638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
approved these changes
Nov 26, 2024
heesung-sn
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23638 +/- ##
============================================
+ Coverage 73.57% 74.36% +0.78%
- Complexity 32624 34997 +2373
============================================
Files 1877 1944 +67
Lines 139502 147200 +7698
Branches 15299 16239 +940
============================================
+ Hits 102638 109458 +6820
- Misses 28908 29284 +376
- Partials 7956 8458 +502
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
added
release/3.3.3
release/3.0.8
release/4.0.1
and removed
release/3.0.9
release/4.0.2
labels
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…ionDataSubscription (apache#23638) (cherry picked from commit 81dfb43) (cherry picked from commit e9c2866)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 28, 2024
…ionDataSubscription (apache#23638) (cherry picked from commit 81dfb43) (cherry picked from commit e9c2866)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I realized that http header data interface is missing in AuthenticationDataSubscription.
It appears that websocket consumer authorization fails because authorization providers cannot pull the authorization header from AuthenticationDataSubscription.
Modifications
added http data interface in AuthenticationDataSubscription
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: