[improve][client] Replace NameUtil#generateRandomName with RandomStringUtils#randomAlphanumeric #23645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Issue: apache/pulsar-client-go#1297
Relative #23577
Motivation
According to #23577 (comment), currently
NameUtil#generateRandomName()
is only used in just few cases. Maybe we could useorg.apache.commons.lang3.RandomStringUtils#randomAlphanumeric(int)
to replace this class for better readability and code structure.Modifications
Based on #23577 (comment) intention:
Remove
NameUtil
completely and use Commons Lang3'sorg.apache.commons.lang3.RandomStringUtils#randomAlphanumeric(int)
method with the parameter 5 to create a random string of 5 characters.Verifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.client.impl.ConsumerImplTest#testAutoGenerateConsumerName
Does this pull request potentially affect one of the following parts:
Default consumer name generating rule will be changed from
[a-f0-9]{5}
to[a-zA-Z0-9]{5}
.Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: