[fix][client] Remove javax.ws.rs-api dependency from client side #23646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies - move RestException and PoliciesUtil to pulsar-broker-common since they are the classes that depend on javax.ws.rs-api and they aren't needed in client side code. - move defaultBundle method to BundlesData
lhotari
requested review from
eolivelli,
nodece,
Technoboy-,
nicoloboschi,
heesung-sn and
dao-jun
2 tasks
heesung-sn
approved these changes
Nov 27, 2024
|
Closing in favor of #23647 since integration tests fail when the dependency is removed from client side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Current pulsar-client 4.0.0 pom includes multiple unwanted dependencies.
It contains the
javax.ws.rs-apidependency which is a server-side dependency. It should be removed.This is one of changes required to remove
javaxdependencies from the shaded Pulsar client, related to #21297.Modifications
javax.ws.rs-apidependency frompulsar-commonmodulejavax.ws.rs-apidependency frompulsar-client-auth-saslmoduleDocumentation
docdoc-requireddoc-not-neededdoc-complete