[fix][build] Fix error "Element encoding is not allowed here" in pom.xml #23655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect element name
lhotari
requested review from
Technoboy-,
nodece,
RobertIndie,
tisonkun,
dao-jun,
shibd and
thetumbled
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23655 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.76%
- Complexity 32624 34481 +1857
============================================
Files 1877 1944 +67
Lines 139502 147242 +7740
Branches 15299 16250 +951
============================================
+ Hits 102638 109452 +6814
- Misses 28908 29335 +427
- Partials 7956 8455 +499
Flags with carried forward coverage won't be shown. Click here to find out more. |
tisonkun
approved these changes
Nov 29, 2024
shibd
approved these changes
Nov 29, 2024
thetumbled
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
IntelliJ shows an xml error in pom.xml, "Element encoding is not allowed here"
Modifications
inputEncodingandoutputEncoding(when applicable) instead ofencodingDocumentation
docdoc-requireddoc-not-neededdoc-complete