Improve Simulation Tools and Add Documentation #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Apr 3, 2017
| @@ -84,7 +84,7 @@ | |||
|
|
|||
| @Parameter(names = { "-c", | |||
| "--max-connections" }, description = "Max number of TCP connections to a single broker") | |||
| public int maxConnections = 0; | |||
| public int maxConnections = -1; | |||
There was a problem hiding this comment.
It is already set that if you pass 0 it will disable the connection pool mechanism. Otherwise the client-lib default would be 1. So, I would say to set the default to 1 in this tool, so that it is more explicit what the resulting number of connection will be.
bin/pulsar-perf
Outdated
| simulation-controller Run a simulation controller to give commands to servers | ||
| produce Run a producer | ||
| consume Run a consumer | ||
| monitor Continuously receive broker data and/or load reports |
There was a problem hiding this comment.
monitor-load-manager? Or can this be used in more general testing scenarios?
There was a problem hiding this comment.
A think monitor-brokers would be good, since it is really just printing out broker data in general.
merlimat
added
the
doc
rdhabalia
pushed a commit
that referenced
this pull request
May 2, 2017
* Add documentation, improve simulation tools. * Add global summary for monitor * monitor -> monitor-brokers * Don't modify performance producer/consumer * Use property/cluster instead of cluster/property for simulation * Fix regex
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
simplify `MessageIdUtils.peekOffsetFromEntry` by use `Commands.peekBrokerEntryMetadataIfExist` directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The load simulation tools introduced in #303 did not yet have documentation and performed crudely in a few cases. This PR adds documentation and improves these tools.
Modifications
Result
The monitor may be started for either load manager using
pulsar-perf monitor. Documentation for simulation tools is now present and those tools have been improved.