RATIS-2206. Jars in Maven repo and binary tarball are not the same #1188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During release process, Ratis is currently re-built from scratch in several steps. Outputs of various steps are published to two different locations.
prepare-src
: builds everything, installs artifacts (jars, tarballs, etc.) in local repoprepare-bin
: verifies that Ratis can be built from the contents of the source tarball created byprepare-src
assembly
: adds src tarball from step (1) and binary tarball from step (2) to Subversionpublish-mvn
: publish artifacts to the Maven repoProblem: Both
prepare-bin
andpublish-mvn
re-build Ratis and install build artifacts to the local repo.Result:
prepare-bin
andpublish-mvn
, respectively.publish-mvn
.This PR updates the release helper script to ensure the artifacts published to Maven repo and those in the binary tarball are the same.
prepare-bin
: build, but do not overwriteassembly
: pick both tarballs created byprepare-src
publish-mvn
: deploy, but do not re-buildhttps://issues.apache.org/jira/browse/RATIS-2206
How was this patch tested?
Executed parts of the release process:
Extracted binary tarball:
Verified that artifacts in various locations are the same.
Excerpts from outputs
prepare-src
Built and installed artifacts to local repo:
prepare-bin
Built from extracted source tarball, but did not overwrite artifacts in local repo.
publish-mvn
Did not rebuild, only tried to publish existing jars. (But failed due to missing credentials, since I did not want to really publish it.)