-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RATIS-2219. Remove duplicate test case from TestRaftWithGrpc #1192
Conversation
On a related note, currently only the 3 methods defined in
Should we also parameterize these? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the change looks good.
TestLeaderInstallSnapshotWithGrpc
also has a similar problem. Would you like to fix it here?
It seems okay to skip those test cases. We should identify test cases for running with parameterized config. |
|
Thanks @szetszwo for reviewing and merging this. |
What changes were proposed in this pull request?
TestRaftWithGrpc#testWithLoad
is run 3 times, twice with the same value forraft.grpc.server.heartbeat.channel
. This happens becausetestWithLoad(boolean)
no longer overridestestWithLoad
from parent class after RATIS-1976.Also, simplify parameterized test cases (use
boolean
instead ofBoolean
).https://issues.apache.org/jira/browse/RATIS-2219
How was this patch tested?