add start and stop script for Counter example #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think whether this patch is useful for Ratis? |
amaliujia
reviewed
Sep 7, 2020
| source $DIR/common.sh | ||
|
|
||
| # One of the examples, e.g. "filestore" or "arithmetic" | ||
| example="$1" |
There was a problem hiding this comment.
It seems to be better to print a list of examples and then allow user to choose (which should include validation)
amaliujia
reviewed
Sep 7, 2020
| example="$1" | ||
| shift | ||
|
|
||
| subcommand="$1" |
amaliujia
reviewed
Sep 7, 2020
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| kill $(jps -lv | grep 'ratis' | grep 'CounterServer' | grep -v 'grep' | awk '{print $1}') |
There was a problem hiding this comment.
Out of curiosity: will this way leave garbages generated by servers locally?
There was a problem hiding this comment.
In fact, I think ratis-examples/src/main/bin./stop-all.sh will server your stop server purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handy tool for start or stop three Ratis server at once
Hello,
I am a new user for Ratis.
I found that in example module, there is no convenient method to start three Ratis server for testing, user have to specified one by one in terminal or IDE.
So, the scripts can be a handy tool for new user testing.
Hope it helpful.
Shucheng Hou