RATIS-1932. Create zero-copy Marshaller #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc. @szetszwo |
szetszwo
approved these changes
Nov 7, 2023
Comment on lines
+26
to
+27
| * Checker to test whether a zero-copy masharller is available from the versions of gRPC and | ||
| * Protobuf. |
There was a problem hiding this comment.
I guess we don't have to check it in Ratis since the gRPC version should have the required classes. Anyway, let keep this class for now. We may consider removing it later.
|
Although these util classes are not yet used, it is going to be very useful later on. Let's merge them first and change other components to use it. |
symious
pushed a commit
to symious/ratis
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
First step of bringing zero-copy support to Ratis GRPC is create a message marshaller in ratis-grpc (GoogleCloudPlatform/grpc-gcp-java#77).
Sample usage can be found from here.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1932
How was this patch tested?
This code path is unused now, test will be added when the feature is implemented as per RATIS-1925 and RATIS-1926.