Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): add maxConsumerTimes to support higher client version #230

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

close #229
feat(version): add maxConsumerTimes to support higher client version

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 14, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 14, 2020
@ShannonDing ShannonDing requested a review from jonnxu January 14, 2020 04:24
@codecov-io
Copy link

Codecov Report

Merging #230 into master will increase coverage by 0.45%.
The diff coverage is 83.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   51.87%   52.33%   +0.45%     
==========================================
  Files         174      174              
  Lines       10858    10931      +73     
==========================================
+ Hits         5633     5721      +88     
+ Misses       5225     5210      -15
Impacted Files Coverage Δ
include/DefaultMQPushConsumer.h 0% <ø> (ø) ⬆️
src/protocol/CommandHeader.h 79.26% <ø> (+2.43%) ⬆️
src/consumer/DefaultMQPushConsumer.cpp 6.44% <0%> (-0.1%) ⬇️
src/consumer/ConsumeMessageConcurrentlyService.cpp 0% <0%> (ø) ⬆️
src/MQClientAPIImpl.cpp 20.28% <100%> (+3.79%) ⬆️
src/protocol/CommandHeader.cpp 85.44% <100%> (+2.22%) ⬆️
test/src/protocol/CommandHeaderTest.cpp 100% <100%> (ø) ⬆️
test/src/MQClientAPIImpTest.cpp 98.37% <100%> (+0.26%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555e19d...4456300. Read the comment docs.

@ShannonDing ShannonDing merged commit 46dd8f5 into apache:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send message back error when client version > 3.4.9
2 participants