Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse unadapted Database to SQL92 dialect and add support for JDBC URLs for commonly used testcontainers #29291

Closed
wants to merge 1 commit into from

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 5, 2023

Fixes #28892.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a database cannot be accurately recognize, there will be a large number of potential complex problems.

@linghengqian
Copy link
Member Author

  • A new PR will create separate Maven submodules for vertica and clickhouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does shardingsphere support clickhosue?
2 participants