Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting hive_conf_list, hive_var_list and sess_var_list for jdbcURL when connecting to HiveServer2 #33749

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

linghengqian
Copy link
Member

For #29052.

Changes proposed in this pull request:

  • Support setting hive_conf_list, hive_var_list and sess_var_list for jdbcURL when connecting to HiveServer2. This is actually a prerequisite for the nativeTest test under GraalVM Native Image to connect to HiveServer2 with Zookeeper service discovery enabled.
  • Due to the change in HIVE-23820: [HS2] Send tableId in request for get_table_request API hive#2153, org.apache.hadoop.hive.metastore.HiveMetaStoreClient#(String, String) has been replaced by org.apache.hadoop.hive.metastore.HiveMetaStoreClient#(org.apache.hadoop.hive.metastore.api.GetTableRequest). Considering that shardingsphere do not test HiveServer2 for 2.x and 3.x like DBeaver, this will not break any unit tests.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

… for jdbcURL when connecting to HiveServer2
@strongduanmu strongduanmu merged commit 6ccd36e into apache:master Nov 21, 2024
147 checks passed
@linghengqian linghengqian deleted the chdb-doc branch November 21, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants