Support prometheus HTTP API and promQL. #10415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once this PR gets merged, please free this public IP. We don't want this gets logged and become a leak one day. |
|
One TODO, complete docs for PromQL. This should be done through next PR. |
wu-sheng
reviewed
Feb 20, 2023
wu-sheng
reviewed
Feb 20, 2023
wu-sheng
reviewed
Feb 20, 2023
wu-sheng
reviewed
Feb 20, 2023
kezhenxu94
reviewed
Feb 20, 2023
...-query-plugin/src/main/java/org/apache/skywalking/oap/query/prometheus/entity/ErrorType.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Feb 20, 2023
...-plugin/src/test/java/org/apache/skywalking/prometheus/rt/parser/PromQLMatchVisitorTest.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Feb 20, 2023
...us-query-plugin/src/main/java/org/apache/skywalking/oap/query/prometheus/rt/PromOpUtils.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Feb 20, 2023
...n/src/main/java/org/apache/skywalking/oap/query/prometheus/handler/PrometheusApiHandler.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Feb 20, 2023
Comment on lines
184
to
186
| @Param("match[]") Optional<String> match, | ||
| @Param("start") Optional<String> start, | ||
| @Param("end") Optional<String> end) throws IOException { |
There was a problem hiding this comment.
Why are these 3 parameters not used but listed here?
There was a problem hiding this comment.
Reserve these param to keep consistent with API protocol, have add commons on methods
kezhenxu94
reviewed
Feb 20, 2023
...ry-plugin/src/main/java/org/apache/skywalking/oap/query/prometheus/entity/TimeValuePair.java
Outdated
Show resolved
Hide resolved
kezhenxu94
reviewed
Feb 22, 2023
...erver-core/src/main/java/org/apache/skywalking/oap/server/core/query/RecordQueryService.java
Outdated
Show resolved
Hide resolved
wu-sheng
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is non-trivial feature, paste the links/URLs to the design doc.
Update the documentation to include this new feature.
Tests(including UT, IT, E2E) are added to verify the new feature.
If it's UI related, attach the screenshots below.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [Feature] investigate the possibility for supporting PromQL #10080 .
Update the
CHANGESlog.Support HTTP API list:
Support basic promQL for query traffic/metrics/labeled_metrics/topN/sampled_records from OAP
A Grafana dashboards demo based on this feature can visit:
http://34.92.90.119:3000/
admin/admin
Include: General Service / Service Mesh / Virtual-Database