Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-3913: Optimize the commit/optimize cycle in the PostTool #2667

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Aug 26, 2024

https://issues.apache.org/jira/browse/SOLR-3913

Description

if you do a opitmize, don't do a commit, otherwise if you request commit do it.

Solution

Be smart about the logic.

Arguably you shouldn't be able to pass in the skip-commit AND the optimize options as the same time...?

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Arguably you shouldn't be able to pass in the skip-commit AND the optimize options as the same time...?
@epugh epugh requested a review from dsmiley August 26, 2024 10:41
@epugh epugh merged commit 94146c1 into apache:main Aug 27, 2024
4 checks passed
epugh added a commit that referenced this pull request Aug 27, 2024
Arguably you shouldn't be able to pass in the skip-commit AND the optimize options as the same time...?

(cherry picked from commit 94146c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants