Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45993][INFRA] scalac: remove deprecated option -target #44387

Closed

Conversation

nchammas
Copy link
Contributor

What changes were proposed in this pull request?

This PR changes the option provided to scalac from -target, which is deprecated, to -release.

Why are the changes needed?

This PR eliminates a bunch of warning that are emitted during compilation that look like this:

[warn] -target is deprecated: Use -release instead to compile against the correct platform API.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

./build/sbt -Phive -Phive-thriftserver clean package
./build/mvn -Phive -Phive-thriftserver -DskipTests clean package

Both of these command run successfully and without emitting the above mentioned warning.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Dec 17, 2023
@nchammas
Copy link
Contributor Author

Following the discussions in #41943 and #42899, it seems we don't want to use -release until some deeper issues related to package visibility across Java versions are resolved.

@nchammas nchammas closed this Dec 17, 2023
@nchammas nchammas deleted the SPARK-45993-scalac-target-release branch December 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant