[SPARK-49700][CONNECT][SQL] Unified Scala Interface for Connect and Classic #48818
+1,815
−1,669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvanhovell
commented
Nov 11, 2024
There was a problem hiding this comment.
This makes Source use the classic API.
hvanhovell
commented
Nov 12, 2024
| @@ -1244,24 +1243,6 @@ class Dataset[T] private[sql]( | |||
| select(replacedAndExistingColumns ++ newColumns : _*) | |||
| } | |||
|
|
|||
| /** @inheritdoc */ | |||
| private[spark] def withColumns( | |||
There was a problem hiding this comment.
Moved to super class.
hvanhovell
commented
Nov 12, 2024
| * Execute a block of code with this session set as the active session, and restore the | ||
| * previous session on completion. | ||
| */ | ||
| private[sql] def withActive[T](block: => T): T = { |
There was a problem hiding this comment.
Moved to super class.
hvanhovell
commented
Nov 12, 2024
| @@ -330,8 +333,6 @@ class SparkSessionBuilderSuite extends SparkFunSuite with Eventually { | |||
| .set(wh, "./data1") | |||
| .set(td, "bob") | |||
|
|
|||
| val sc = new SparkContext(conf) | |||
hvanhovell
commented
Nov 13, 2024
There was a problem hiding this comment.
I can spin this off in a separate PR.
hvanhovell
commented
Nov 13, 2024
|
|
||
| // The only way this could have ever worked if this is effectively a no-op. |
There was a problem hiding this comment.
Will remove in the next iteration.
|
For anyone interested. This is mostly ready for review. I still looking at some of the developer API, most of it uses classic now, however in most cases the interfaces should suffice. Moving them back might make the lives of spark library developers at bit easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the shared SQL (JVM) interface the primary interface.
The implementations are moved to the
classicandconnectsub packages.Please note that this does change a number of developer APIs:
Why are the changes needed?
This is the final step in creating a unified Scala interface for both Classic and Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.