[SPARK-50287][SQL] Merge options of table and relation when creating WriteBuilder in FileTable #48821
+57
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iteBuilder in FileTable
dongjoon-hyun
approved these changes
Nov 13, 2024
cloud-fan
reviewed
Nov 14, 2024
| @@ -39,10 +39,17 @@ case class TextTable( | |||
| override def inferSchema(files: Seq[FileStatus]): Option[StructType] = | |||
| Some(StructType(Array(StructField("value", StringType)))) | |||
|
|
|||
| override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = | |||
| override def newWriteBuilder(info: LogicalWriteInfo): WriteBuilder = { | |||
| val writeInfo = LogicalWriteInfoImpl( | |||
There was a problem hiding this comment.
shall we have one method in the parent class to create LogicalWriteInfoImpl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Merge
optionsof table and relation when creating WriteBuilder in FileTable.Why are the changes needed?
Similar to SPARK-49519 which fixes the read path.
Does this PR introduce any user-facing change?
FileTable's options are accounted on the V2 write path now, but given the built-in file formats use V1 by default, it has no real effect.
How was this patch tested?
UT is updated to cover the case.
Was this patch authored or co-authored using generative AI tooling?
No.