[SPARK-50130][SQL][FOLLOWUP] Make Encoder generation lazy #48829
+27
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Nov 13, 2024
|
shall we add a test for it? |
xinrong-meng
approved these changes
Nov 13, 2024
cloud-fan
reviewed
Nov 13, 2024
cloud-fan
reviewed
Nov 14, 2024
| @@ -95,13 +95,12 @@ private[sql] object Dataset { | |||
| def ofRows(sparkSession: SparkSession, logicalPlan: LogicalPlan): DataFrame = | |||
| sparkSession.withActive { | |||
| val qe = sparkSession.sessionState.executePlan(logicalPlan) | |||
| val encoder = if (qe.isLazyAnalysis) { | |||
| RowEncoder.encoderFor(new StructType()) | |||
| if (qe.isLazyAnalysis) { | |||
There was a problem hiding this comment.
can we clean up the code a bit more?
if (!qe.isLazyAnalysis) qe.assertAnalyzed()
new Dataset[Row](qe, () => RowEncoder.encoderFor(qe.analyzed.schema))
There was a problem hiding this comment.
Now with this PR, the encoder creation is lazy only when qe.isLazyAnalysis, to be consistent with the current behavior. Also the previously failed test suggested to make it consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Makes Encoder generation lazy.
Why are the changes needed?
The encoder with empty schema for lazy plan could cause unexpected behavior.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.