[SPARK-45891][SQL] Rebuild variant binary from shredded data. #48851
+434
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhao-db
force-pushed
the
rebuild_variant
branch
from
16ca3bd
to
99d806f
Compare
chenhao-db
force-pushed
the
rebuild_variant
branch
from
99d806f
to
a5119a5
Compare
|
@gene-db @cashmand @cloud-fan could you help review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It implements the variant rebuild functionality according to the current shredding spec in apache/parquet-format#461, and allows the Parquet reader will be able to read shredded variant data.
Why are the changes needed?
It gives Spark the basic ability to read shredded variant data. It can be improved in the future to read only requested fields.
Does this PR introduce any user-facing change?
Yes, the Parquet reader will be able to read shredded variant data.
How was this patch tested?
Unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.