Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-5411 General code clean up using modern language features #1003

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Jul 25, 2024

WW-5411

Applied most of the trivial Intellij inspection fixes to the Struts Core module and a few other miscellaneous clean ups.

@kusalk kusalk force-pushed the 7.0.x/WW-5411-delete-deprecated-2 branch from 78e0198 to d1d2102 Compare July 25, 2024 15:41
@kusalk kusalk force-pushed the 7.0.x/WW-5411-delete-deprecated-2 branch from d1d2102 to 35d9c0b Compare July 25, 2024 15:48
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
74.2% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@kusalk kusalk marked this pull request as ready for review July 25, 2024 16:06
@kusalk kusalk requested a review from lukaszlenart July 25, 2024 16:06
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@kusalk kusalk merged commit 5cd03aa into release/struts-7-0-x Jul 26, 2024
6 of 7 checks passed
@kusalk kusalk deleted the 7.0.x/WW-5411-delete-deprecated-2 branch July 26, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants