Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-5454 Log warnings on startup for disabled critical security features #1010

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Aug 3, 2024

WW-5454

This PR adds startup log warnings for disabling the following capabilities:

  • OGNL class allowlist
  • @StrutsParameter annotation requirement

/**
* @since 7.0
*/
public static void logWarningForFirstOccurrence(String key, Logger log, String msg, Object... args) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method isn't really a DebugUtils method but couldn't think of a better home - can create a separate class if you prefer

@kusalk kusalk marked this pull request as ready for review August 3, 2024 10:31
Copy link

sonarcloud bot commented Aug 3, 2024

@kusalk kusalk requested a review from lukaszlenart August 3, 2024 10:32
@kusalk kusalk merged commit 3267a1a into release/struts-7-0-x Aug 6, 2024
7 checks passed
@kusalk kusalk deleted the 7.0.x/WW-5454-log-security-warnings branch August 6, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants