Minor Formatting changes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sdutry
commented
Jan 3, 2018
sdutry
commented
- made some minor formatting changes concerning:
- mixed tabs and spaces
- add curly brackets around single line conditional statements
- added some missing ´@OverRide´ annotations
- add curly brackets around single line conditional statements - place finally statement on same line as closing catch bracket
- add curly brackets around single line conditional statements
|
Looks good to me but it would be nice if you could increase coverage to satisfy Coveralls :) |
I'll look into it. |
Test that a ConfigurationException is thrown when the TemplateEngineManager returns null instead of a TemplateEngine instance.
|
@lukaszlenart
to
|
Verified that: - default template name gets picked when no specific one is given - specific template gets precedence over default one
Verified that:
- explicit templateDirectory gets precedence
- attribute templateDir gets picked if no explitit one is given
- defaultTemplateDirectory gets picked if there is no explicit one and
an attribute templateDid
- "template" is returned as default value
Verified that the value is added to the parameters after they have been evaluated.
Verified that the value parameter is added as the nameValue parameter.
|
💯 |
|
@sdutry ready to be merged? |
I think so. Maybe the following piece of comment should be removed? /**
*
* @version $Date$ $Id$
*/
public class UIBeanTest extends StrutsInternalTestCase { |
|
Yes, please do, those are some leftovers from Subversion - not in use anymore |
|
nice, LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.