WW-5409 introduce final attribute to package element which make them unextendable #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferyxhy
commented
Apr 11, 2024
core/src/main/java/org/apache/struts2/config/StrutsXmlConfigurationProvider.java
Outdated
Show resolved
Hide resolved
kusalk
deleted the
issue/WW-5409-introduce-final-attribute-to-package-element
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-5409
Reason
Extending packages is a very useful capability of Struts but there are some quirks, that if a developer is not aware of, can lead to critical vulnerabilities. One such misunderstood quirk is the default-interceptor-ref element.
e.g. a parent package add permission interceptor for its action (say Action A), while child package extends parent package will inherit its actions but not interceptor. So if the develop is not aware of this, then Action A is now exposed with permission vuln through child package's namespace.
Changes/ Solution
introduce new
finalattribute onpackageelement which will make it is unextendableResult & Impact
finalattribute is implied asfalse, so no difference.finalattribute explicitly astrue, will make this package unextendable, so any extends to this package will cause a ConfigurationException to be thrown during application struts config xml load step.