chore: add eslint react fragment rule (#32)

* chore: add eslint react fragment rule * fix: lint * fix: react16
apache · Nov 25, 2021 · 419dcd5 · 419dcd5
1 parent 960ef09
commit 419dcd5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json
@@ -38,7 +38,7 @@
   ],
   "license": "Apache-2.0",
   "devDependencies": {
-    "@superset-ui/build-config": "^0.0.4",
+    "@superset-ui/build-config": "^0.0.6",
     "@superset-ui/chart": "^0.10.8",
     "@superset-ui/color": "^0.10.0",
     "@superset-ui/connection": "^0.10.0",

diff --git a/...superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json b/...superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json
@@ -53,6 +53,6 @@
     "@superset-ui/number-format": "^0.10.0",
     "@superset-ui/time-format": "^0.10.0",
     "@superset-ui/translation": "^0.10.0",
-    "react": "^15 || ^16"
+    "react": "^16.2"
   }
 }
diff --git a/...ugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx b/...ugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx
@@ -20,7 +20,7 @@ export default function createTooltip(encoder: Encoder, allSeries: Series[]) {
   }) {
     return (
       <TooltipFrame>
-        <React.Fragment>
+        <>
           <div>
             <strong>{encoder.channels.x.formatValue(datum.x)}</strong>
           </div>
@@ -41,7 +41,7 @@ export default function createTooltip(encoder: Encoder, allSeries: Series[]) {
                 }))}
             />
           )}
-        </React.Fragment>
+        </>
       </TooltipFrame>
     );
   }

diff --git a/...s/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx b/...s/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx
@@ -86,6 +86,6 @@ export default class ChartLegend<
       );
     });
 
-    return <React.Fragment>{legends}</React.Fragment>;
+    return <>{legends}</>;
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,6 +86,6 @@ export default class ChartLegend< @@
           );
         });
-        return <React.Fragment>{legends}</React.Fragment>;
+        return <>{legends}</>;
       }
     }