Unpack ternary.

apache · Jul 26, 2022 · 5e3a927 · 5e3a927
1 parent 1f69feb
commit 5e3a927
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/superset-frontend/src/explore/components/ControlHeader.tsx b/superset-frontend/src/explore/components/ControlHeader.tsx
@@ -65,11 +65,15 @@ const ControlHeader: FC<ControlHeaderProps> = ({
       hasHadNoErrors.current = true;
     }
 
-    return hasHadNoErrors.current
-      ? validationErrors.length
-        ? colors.error.base
-        : 'unset'
-      : colors.alert.base;
+    if (hasHadNoErrors.current) {
+      if (validationErrors.length) {
+        return colors.error.base;
+      }
+
+      return 'unset';
+    }
+
+    return colors.alert.base;
   }, [colors.error.base, colors.alert.base, validationErrors.length]);
 
   if (!label) {