Skip to content

Commit

Permalink
[hotfix] iframe viz is broken
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Apr 6, 2017
1 parent 7a08cdc commit 9c99be5
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import $ from 'jquery';
import Mustache from 'mustache';
import React, { PropTypes } from 'react';
import { connect } from 'react-redux';
import { Alert, Collapse, Label, Panel } from 'react-bootstrap';
Expand Down Expand Up @@ -104,6 +105,14 @@ class ChartContainer extends React.PureComponent {

height: getHeight,

render_template: function (s) {

This comment has been minimized.

Copy link
@ascott

ascott Apr 6, 2017

i believe this syntax is breaking the js tests. should be render_template: (s) => {

This comment has been minimized.

Copy link
@ascott

ascott Apr 6, 2017

fixed it here ascott@9f81f17

This comment has been minimized.

Copy link
@mistercrunch

mistercrunch Apr 7, 2017

Author Member

oops, thanks for cleaning my mistake!

const context = {
width: this.width,
height: this.height,
};
return Mustache.render(s, context);
},

setFilter: () => {},

getFilters: () => (
Expand Down
2 changes: 1 addition & 1 deletion superset/assets/javascripts/explorev2/stores/controls.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ export const controls = {
label: 'URL',
description: 'The URL, this control is templated, so you can integrate ' +
'{{ width }} and/or {{ height }} in your URL string.',
default: 'https: //www.youtube.com/embed/JkI5rg_VcQ4',
default: 'https://www.youtube.com/embed/AdSZJzb-aX8',
},

x_axis_label: {
Expand Down
2 changes: 1 addition & 1 deletion superset/assets/javascripts/modules/superset.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import $ from 'jquery';
const Mustache = require('mustache');
const utils = require('./utils');
// vis sources
/* eslint camel-case: 0 */
import Mustache from 'mustache';
import vizMap from '../../visualizations/main.js';
import { getExploreUrl } from '../explorev2/exploreUtils';
import { applyDefaultFormData } from '../explorev2/stores/store';
Expand Down

0 comments on commit 9c99be5

Please sign in to comment.