Merge pull request #151 from mistercrunch/lint

Linting

README.md

@@ -4,6 +4,7 @@ Panoramix
 [![Join the chat at https://gitter.im/mistercrunch/panoramix](https://badges.gitter.im/mistercrunch/panoramix.svg)](https://gitter.im/mistercrunch/panoramix?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 ![img](https://travis-ci.org/mistercrunch/panoramix.svg?branch=master)
 [![Coverage Status](https://coveralls.io/repos/mistercrunch/panoramix/badge.svg?branch=master&service=github)](https://coveralls.io/github/mistercrunch/panoramix?branch=master)
+[![Code Health](https://landscape.io/github/mistercrunch/panoramix/immune_to_filter/landscape.svg?style=flat)](https://landscape.io/github/mistercrunch/panoramix/immune_to_filter)
 
 Panoramix is a data exploration platform designed to be visual, intuitive
 and interactive.

panoramix/__init__.py

@@ -4,7 +4,6 @@
 from flask.ext.appbuilder import SQLA, AppBuilder, IndexView
 from flask.ext.appbuilder.baseviews import expose
 from flask.ext.migrate import Migrate
-from panoramix import config
 
 
 APP_DIR = os.path.dirname(__file__)
@@ -34,4 +33,4 @@ def index(self):
 sm = appbuilder.sm
 
 get_session = appbuilder.get_session
-from panoramix import views
+from panoramix import config, views

panoramix/config.py

@@ -1,16 +1,16 @@
+"""
+All configuration in this file can be overridden by providing a local_config
+in your PYTHONPATH.
+
+There' a ``from local_config import *`` at the end of this file.
+"""
 import os
 from flask_appbuilder.security.manager import AUTH_DB
 # from flask_appbuilder.security.manager import (
 #    AUTH_OID, AUTH_REMOTE_USER, AUTH_DB, AUTH_LDAP, AUTH_OAUTH)
 BASE_DIR = os.path.abspath(os.path.dirname(__file__))
 from dateutil import tz
 
-"""
-All configuration in this file can be overridden by providing a local_config
-in your PYTHONPATH.
-
-There' a ``from local_config import *`` at the end of this file.
-"""
 
 # ---------------------------------------------------------
 # Panoramix specifix config
@@ -133,5 +133,5 @@
 
 try:
     from panoramix_config import *
-except:
+except Exception:
     pass

panoramix/data/countries.py

@@ -684,7 +684,7 @@
         "area": 4167,
         "cioc": "",
         "cca2": "PF",
-        "capital": "Papeet\u0113",
+        "capital": u"Papeet\u0113",
         "lat": -15,
         "lng": -140,
         "cca3": "PYF"
@@ -754,7 +754,7 @@
         "area": 56785,
         "cioc": "TOG",
         "cca2": "TG",
-        "capital": "Lom\u00e9",
+        "capital": u"Lom\u00e9",
         "lat": 8,
         "lng": 1.16666666,
         "cca3": "TGO"
@@ -774,7 +774,7 @@
         "area": 549,
         "cioc": "GUM",
         "cca2": "GU",
-        "capital": "Hag\u00e5t\u00f1a",
+        "capital": u"Hag\u00e5t\u00f1a",
         "lat": 13.46666666,
         "lng": 144.78333333,
         "cca3": "GUM"
@@ -834,7 +834,7 @@
         "area": 51100,
         "cioc": "CRC",
         "cca2": "CR",
-        "capital": "San Jos\u00e9",
+        "capital": u"San Jos\u00e9",
         "lat": 10,
         "lng": -84,
         "cca3": "CRI"
@@ -844,7 +844,7 @@
         "area": 475442,
         "cioc": "CMR",
         "cca2": "CM",
-        "capital": "Yaound\u00e9",
+        "capital": u"Yaound\u00e9",
         "lat": 6,
         "lng": 12,
         "cca3": "CMR"
@@ -1070,7 +1070,7 @@
         "cca3": "BLR"
     },
     {
-        "name": "Saint Barth\u00e9lemy",
+        "name": u"Saint Barth\u00e9lemy",
         "area": 21,
         "cioc": "",
         "cca2": "BL",
@@ -1274,7 +1274,7 @@
         "area": 7747,
         "cioc": "",
         "cca2": "TF",
-        "capital": "Port-aux-Fran\u00e7ais",
+        "capital": u"Port-aux-Fran\u00e7ais",
         "lat": -49.25,
         "lng": 69.167,
         "cca3": "ATF"
@@ -1380,7 +1380,7 @@
         "cca3": "PER"
     },
     {
-        "name": "R\u00e9union",
+        "name": u"R\u00e9union",
         "area": 2511,
         "cioc": "",
         "cca2": "RE",
@@ -1484,7 +1484,7 @@
         "area": 1141748,
         "cioc": "COL",
         "cca2": "CO",
-        "capital": "Bogot\u00e1",
+        "capital": u"Bogot\u00e1",
         "lat": 4,
         "lng": -72,
         "cca3": "COL"
@@ -1534,7 +1534,7 @@
         "area": 33846,
         "cioc": "MDA",
         "cca2": "MD",
-        "capital": "Chi\u0219in\u0103u",
+        "capital": u"Chi\u0219in\u0103u",
         "lat": 47,
         "lng": 29,
         "cca3": "MDA"
@@ -1594,7 +1594,7 @@
         "area": 300,
         "cioc": "MDV",
         "cca2": "MV",
-        "capital": "Mal\u00e9",
+        "capital": u"Mal\u00e9",
         "lat": 3.25,
         "lng": 73,
         "cca3": "MDV"
@@ -1620,7 +1620,7 @@
         "cca3": "SPM"
     },
     {
-        "name": "Cura\u00e7ao",
+        "name": u"Cura\u00e7ao",
         "area": 444,
         "cioc": "",
         "cca2": "CW",
@@ -1704,7 +1704,7 @@
         "area": 1393,
         "cioc": "",
         "cca2": "FO",
-        "capital": "T\u00f3rshavn",
+        "capital": u"T\u00f3rshavn",
         "lat": 62,
         "lng": -7,
         "cca3": "FRO"
@@ -1860,7 +1860,7 @@
         "cca3": "TUV"
     },
     {
-        "name": "\u00c5land Islands",
+        "name": u"\u00c5land Islands",
         "area": 1580,
         "cioc": "",
         "cca2": "AX",
@@ -1914,7 +1914,7 @@
         "area": 8515767,
         "cioc": "BRA",
         "cca2": "BR",
-        "capital": "Bras\u00edlia",
+        "capital": u"Bras\u00edlia",
         "lat": -10,
         "lng": -55,
         "cca3": "BRA"
@@ -2334,7 +2334,7 @@
         "area": 266000,
         "cioc": "",
         "cca2": "EH",
-        "capital": "El Aai\u00fan",
+        "capital": u"El Aai\u00fan",
         "lat": 24.5,
         "lng": -13,
         "cca3": "ESH"
@@ -2394,7 +2394,7 @@
         "area": 18575,
         "cioc": "",
         "cca2": "NC",
-        "capital": "Noum\u00e9a",
+        "capital": u"Noum\u00e9a",
         "lat": -21.5,
         "lng": 165.5,
         "cca3": "NCL"

panoramix/migrations/env.py

@@ -3,7 +3,6 @@
 from sqlalchemy import engine_from_config, pool
 from logging.config import fileConfig
 import logging
-from panoramix import db, models
 from flask.ext.appbuilder import Base
 
 # this is the Alembic Config object, which provides

panoramix/migrations/versions/1e2841a4128_.py

@@ -12,15 +12,10 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
 
 def upgrade():
-    ### commands auto generated by Alembic - please adjust! ###
     op.add_column('table_columns', sa.Column('expression', sa.Text(), nullable=True))
-    ### end Alembic commands ###
 
 
 def downgrade():
-    ### commands auto generated by Alembic - please adjust! ###
     op.drop_column('table_columns', 'expression')
-    ### end Alembic commands ###

panoramix/migrations/versions/2929af7925ed_tz_offsets_in_data_sources.py

@@ -12,7 +12,6 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
 
 def upgrade():
     op.add_column('datasources', sa.Column('offset', sa.Integer(), nullable=True))

panoramix/migrations/versions/430039611635_log_more.py

@@ -12,7 +12,6 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
 
 def upgrade():
     op.add_column('logs', sa.Column('dashboard_id', sa.Integer(), nullable=True))

panoramix/migrations/versions/43df8de3a5f4_dash_json.py

@@ -12,10 +12,11 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
+
 
 def upgrade():
     op.add_column('dashboards', sa.Column('json_metadata', sa.Text(), nullable=True))
 
+
 def downgrade():
     op.drop_column('dashboards', 'json_metadata')

panoramix/migrations/versions/5a7bad26f2a7_.py

@@ -12,7 +12,7 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
+
 
 def upgrade():
     op.add_column('dashboards', sa.Column('css', sa.Text(), nullable=True))

panoramix/migrations/versions/7dbf98566af7_slice_description.py

@@ -12,7 +12,6 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
 
 def upgrade():
     op.add_column('slices', sa.Column('description', sa.Text(), nullable=True))

panoramix/migrations/versions/d827694c7555_css_templates.py

@@ -12,7 +12,6 @@
 
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import mysql
 
 
 def upgrade():