New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Funnel]bug and enhancement request #14534

Closed

junlincc opened this issue May 8, 2021 · 1 comment

Labels

assigned:brix #bug viz:charts:funnel

Member

junlincc commented May 8, 2021

Add ORDER BY to get the top values when user select a row limit, currently showing random values

proper treatment for null value, currently funnel doesn't show when there's a null value

junlincc added #bug viz:charts:funnel assigned:brix labels

Contributor

xiezhongfu commented May 9, 2021

The related discussion is apache-superset/superset-ui#1006 (comment)
I misunderstood the discussion.... SHOULD add orderby in SQL to avoid random values

xiezhongfu mentioned this issue

fix(plugin-chart-echarts): add orderby to funnel chart apache-superset/superset-ui#1099

Merged

zhaoyongjie closed this as completed in


      apache-superset/superset-ui@b51a77e

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          fix(plugin-chart-echarts): add orderby to funnel chart (apache#1099)

02a2261

* fix(plugin-chart-echarts): add orderby

fix apache#14534

* feat(plugin-chart-echarts): set orderby default value is true

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          fix(plugin-chart-echarts): add orderby to funnel chart (apache#1099)

59d6505

* fix(plugin-chart-echarts): add orderby

fix apache#14534

* feat(plugin-chart-echarts): set orderby default value is true

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          fix(plugin-chart-echarts): add orderby to funnel chart (apache#1099)

a183afe

* fix(plugin-chart-echarts): add orderby

fix apache#14534

* feat(plugin-chart-echarts): set orderby default value is true

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this issue


          fix(plugin-chart-echarts): add orderby to funnel chart (apache#1099)

e994fc0

* fix(plugin-chart-echarts): add orderby

fix apache#14534

* feat(plugin-chart-echarts): set orderby default value is true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment