Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[echarts]Support Extra Controls on the Time-Series Area Chart for feature parity #16298

Closed
etr2460 opened this issue Aug 17, 2021 · 5 comments
Closed
Assignees
Labels
enhancement:committed Enhancement planned / committed by a contributor viz:charts:area Related to the Area chart viz:charts:echarts Related to Echarts viz:nvd3

Comments

@etr2460
Copy link
Member

etr2460 commented Aug 17, 2021

Is your feature request related to a problem? Please describe.
The new time series area chart doesn't allow the viewer of a chart on a dashboard to toggle between a stacked view (with the metric values) and the expanded view (showing percent contribution). This is a really commonly used feature on the nvd3 area chart that should be supported in the new one for feature parity.

The control on the nvd3 area chart:
image

Describe the solution you'd like
Allow a chart viewer to switch between stacked and expanded views for the area chart using a control on the chart itself

cc: @junlincc and maybe @villebro? Not sure who's owning the echarts migration

@etr2460 etr2460 added viz:charts:echarts Related to Echarts viz:charts:area Related to the Area chart viz:nvd3 labels Aug 17, 2021
@junlincc
Copy link
Member

junlincc commented Aug 18, 2021

@etr2460 absolutely! it's in our todo list. will get to it asap. please file issues if you see anything is missing in new time-series bar, area and line. we would love to get to full feature parity within a month or so.

@junlincc
Copy link
Member

junlincc commented Aug 18, 2021

@stephenLYZ i don't think echarts offer those option out of the box, feel free to open a PR in Echarts and we can expedite it.
In terms of UI, they dont have to be under "extra control", we can use
antd radio or button, maybe button for better consistency.
Screen Shot 2021-08-17 at 10 00 50 PM

cc @villebro

@junlincc junlincc self-assigned this Aug 18, 2021
@junlincc junlincc added the enhancement:committed Enhancement planned / committed by a contributor label Aug 18, 2021
@junlincc junlincc changed the title Support Extra Controls on the Time-Series Area Chart for feature parity [echarts]Support Extra Controls on the Time-Series Area Chart for feature parity Aug 18, 2021
@junlincc
Copy link
Member

@stephenLYZ ^^ lmk if you've seen this issue, take your time to finish other tasks first. thank you thank you!🙏

@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 19, 2022
@jhult
Copy link
Contributor

jhult commented Apr 20, 2022

Bump.

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:committed Enhancement planned / committed by a contributor viz:charts:area Related to the Area chart viz:charts:echarts Related to Echarts viz:nvd3
Projects
None yet
Development

No branches or pull requests

4 participants