-
Notifications
You must be signed in to change notification settings - Fork 272
feat(plugin-chart-echarts): [feature-parity] support Extra Control on the time-series area chart #1336
feat(plugin-chart-echarts): [feature-parity] support Extra Control on the time-series area chart #1336
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2CSgVuvAhrT6gaJNY7TpdHvSRsSC [Deployment for 1247c74 failed] |
Codecov Report
@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 30.43% 29.98% -0.45%
==========================================
Files 497 489 -8
Lines 10000 9882 -118
Branches 1689 1666 -23
==========================================
- Hits 3043 2963 -80
+ Misses 6711 6676 -35
+ Partials 246 243 -3
Continue to review full report at Codecov.
|
f6df01e
to
5243a8e
Compare
@stephenLYZ thank you for the improvement! we probably dont need the buttons at the top - the original one is pretty much a design debt. and i wonder how it goes with legend enabled? @villebro wdyt? |
@stephenLYZ and @villebro, any news on this? We would love to see this get merged. Would this also cover bar charts? If not, once this is merged, could that be easily added? |
@jhult yeah. In the next step I will style it to be compatible with the previous design, and then open another PR to cover the bar chart |
5243a8e
to
185dd8a
Compare
Since we did the migration of the superset mono repo, all the changes are put here apache/superset#16493. |
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:
If you need help with the migration, please post a message on the SIP or reach out on the community Slack. |
🏆 Enhancements
This PR implements
Extra Control
on the time-series area chart, and the chart's update mechanism is usingsetControlValue
hook. In addition, I changed the stack checkbox control to select control. WhenExtra Control
is updated, the control panel will be updated as well, and vice versa. (this is different from NVD3, where updating extra control does not update the control panel). Since 'Stacked' and 'Expended' seem to be used more often, I only keep these two options.Another UI difference is that the button is used instead of the radio to maintain consistency with the control panel.
Refers to :
Extra Controls
on the Time-Series Area Chart for feature parity apache/superset#16298.cc @villebro @zhaoyongjie @junlincc
explore
before
2021-08-29.8.49.16.mov
after
2021-08-29.8.51.51.mov
dashboard
before
2021-08-29.8.53.38.mov
after
2021-08-29.8.54.37.mov