Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate "Run Query" and "Run Async" in SQL Lab to "Run Query" #1819

Closed
jefffeng opened this issue Dec 13, 2016 · 5 comments
Closed

Consolidate "Run Query" and "Run Async" in SQL Lab to "Run Query" #1819

jefffeng opened this issue Dec 13, 2016 · 5 comments
Assignees
Labels
airbnb Airbnb related enhancement:request Enhancement request submitted by anyone from the community sqllab Namespace | Anything related to the SQL Lab

Comments

@jefffeng
Copy link

This is a feature to help simplify the UX for users. Users should not have to choose whether to run a query in the standard mode or run a query asynchronously.

Could we run the query in both modes and automatically fail over to running the query running asynchronously if the standard query fails? Open to other ideas as well...

@jefffeng jefffeng added airbnb Airbnb related enhancement:request Enhancement request submitted by anyone from the community sqllab Namespace | Anything related to the SQL Lab labels Dec 13, 2016
@ascott
Copy link

ascott commented Dec 14, 2016

i was thinking that if running async is an available option, just run async, if not, run sync. we should just show 1 button that reads run query

@jefffeng jefffeng changed the title Consolidate "Run Query" and "Run Async" in SQL Lab Consolidate "Run Query" and "Run Async" in SQL Lab to "Run Query" Dec 16, 2016
@jefffeng
Copy link
Author

Makes sense @ascott. I spoke to @mistercrunch and I am onboard with your suggested approach

@ascott ascott self-assigned this Dec 16, 2016
@ascott
Copy link

ascott commented Dec 16, 2016

going to tackle this today.

@ascott
Copy link

ascott commented Jan 14, 2017

#1858

@ascott ascott closed this as completed Jan 14, 2017
@santhavathi
Copy link

@ascott, the one button that is showed does not run the query asynchronously though the tooltip shows "Run Query Asynchronously". I am using superset 0.17, since there are issues with 0.17.5 mentioned in #2643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airbnb Airbnb related enhancement:request Enhancement request submitted by anyone from the community sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

3 participants